Messages in this thread | | | Subject | Re: [PATCH v6 1/9] nvmem: Add a simple NVMEM framework for nvmem providers | From | Pantelis Antoniou <> | Date | Tue, 23 Jun 2015 10:26:28 +0100 |
| |
Hi Joe,
> On Jun 23, 2015, at 05:52 , Joe Perches <joe@perches.com> wrote: > > On Tue, 2015-06-23 at 00:08 +0100, Srinivas Kandagatla wrote: >> This patch adds just providers part of the framework just to enable easy >> review. > [] >> include/linux/nvmem-provider.h | 54 ++++++ > > Unless there are going to be users of nvmem-provider.h > outside of the drivers/nvmem directory, perhaps that > file (and nvmem-consumer.h) should be in drivers/nvmem/ > >
nvmem-consumer.h should be accessible from any driver, no?
And unfortunately nvmem-provider should be accessible too. There are already eeprom drivers in the eeprom/misc directory that cannot be moved yet to drivers/nvmem (like at24).
They need the provider definitions while they provide both the old style interface, and the new NVMEM based one.
When we move them to the drivers/nvmem directory, then yes the provider header file should move there.
Regards
— Pantelis
| |