Messages in this thread | | | Date | Sun, 21 Jun 2015 22:06:16 -0700 | Subject | Re: [PATCH 3/4] power: Add Qualcomm SMBB driver | From | Bjorn Andersson <> |
| |
On Fri, Jun 19, 2015 at 10:01 AM, Paul Bolle <pebolle@tiscali.nl> wrote: > On Thu, 2015-06-18 at 14:13 -0700, Bjorn Andersson wrote: >> --- /dev/null >> +++ b/drivers/power/qcom_smbb.c > >> +MODULE_ALIAS("platform:qcom_smbb"); > > (The day before yesterday and yesterday I had a, well, lively > conversation regarding this macro. The interesting bits start at > https://lkml.org/lkml/2015/6/17/383 . > > But in a converstaion today things were rather silent. See > https://lkml.org/lkml/2015/6/19/68 and the reply, of sorts, in > https://lkml.org/lkml/2015/6/19/117. Let's see what happens here.) > > As I understand it, this alias is only useful if there's a corresponding > struct platform_device, somewhere. Ie, this alias implies a > platform_device that will fire of a "MODALIAS=platform:qcom_smbb" uevent > when it's created. That would be a platform_device using a "qcom_smbb" > name. >
As far as I could see the uevents, including MODALIAS, is sent when the device is added or removed; but the content comes from the device tree alias, not the MODULE_ALIAS.
The MODULE_ALIAS seems to add an alias to the kernel module information, which can be used to find this driver during modprobe; in addition to the actual name of the module.
> If that's correct, then I think this MODULE_ALIAS macro isn't needed > here, as I couldn't find a platform_device using that name. (But perhaps > a patch that adds it is pending, somewhere.) >
I don't see any reason for keeping the MODULE_ALIAS, so I think it should be removed for v2.
Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/
| |