lkml.org 
[lkml]   [2015]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4.0 050/105] i2c: hix5hd2: Fix modalias to make module auto-loading work
From
Date
On Fri, 2015-06-19 at 13:35 -0700, Greg Kroah-Hartman wrote:
> Make the modalias match driver name, this is required to make module
> auto-loading work.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> Acked-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> ---
> drivers/i2c/busses/i2c-hix5hd2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/i2c/busses/i2c-hix5hd2.c
> +++ b/drivers/i2c/busses/i2c-hix5hd2.c
> @@ -554,4 +554,4 @@ module_platform_driver(hix5hd2_i2c_drive
> MODULE_DESCRIPTION("Hix5hd2 I2C Bus driver");
> MODULE_AUTHOR("Wei Yan <sledge.yanwei@huawei.com>");
> MODULE_LICENSE("GPL");
> -MODULE_ALIAS("platform:i2c-hix5hd2");
> +MODULE_ALIAS("platform:hix5hd2-i2c");

How does this work?

My current understanding is that for module auto-loading to work with
the platform: prefix one needs a matching platform_device (ie, a struct
platform_device with .name being "hix5hd2-i2c"). And I couldn't spot
where that platform_device is created in 4.0 or v4.1.

Does matching platform_driver.driver.name (which is what this patch
appears to do) also enable module auto-loading? That would mean there's
another, even less obvious, mechanism at work here.

Thanks,


Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2015-06-22 16:41    [W:0.605 / U:1.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site