lkml.org 
[lkml]   [2015]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/15] KVM: MTRR: clean up mtrr default type

Thanks for your review, Paolo!


On 06/01/2015 05:11 PM, Paolo Bonzini wrote:

>> struct kvm_vcpu_arch {
>> diff --git a/arch/x86/kvm/mtrr.c b/arch/x86/kvm/mtrr.c
>> index 562341b..6de49dd 100644
>> --- a/arch/x86/kvm/mtrr.c
>> +++ b/arch/x86/kvm/mtrr.c
>> @@ -105,7 +105,6 @@ EXPORT_SYMBOL_GPL(kvm_mtrr_valid);
>> static void update_mtrr(struct kvm_vcpu *vcpu, u32 msr)
>> {
>> struct kvm_mtrr *mtrr_state = &vcpu->arch.mtrr_state;
>> - unsigned char mtrr_enabled = mtrr_state->enabled;
>> gfn_t start, end, mask;
>> int index;
>> bool is_fixed = true;
>> @@ -114,7 +113,7 @@ static void update_mtrr(struct kvm_vcpu *vcpu, u32 msr)
>> !kvm_arch_has_noncoherent_dma(vcpu->kvm))
>> return;
>>
>> - if (!(mtrr_enabled & 0x2) && msr != MSR_MTRRdefType)
>> + if (!mtrr_state->mtrr_enabled && msr != MSR_MTRRdefType)
>
> I know Linus doesn't like bitfields too much. Can you change these to
> inline functions, and only leave an "u64 deftype" in the struct?
>

Sure. I will introduce mtrr_is_enabled() and fixed_mtrr_is_enabled() instead
of these bitfields.



\
 
 \ /
  Last update: 2015-06-03 04:21    [W:0.934 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site