lkml.org 
[lkml]   [2015]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 04/11] nvmem: Add a simple NVMEM framework for consumers
    On Tue, Jun 16, 2015 at 03:29:25PM -0700, Stephen Boyd wrote:
    > On 05/21/2015 09:43 AM, Srinivas Kandagatla wrote:
    > > + /* if it's not end on byte boundary */
    > > + if ((nbits + bit_offset) % BITS_PER_BYTE) {
    > > + /* setup the last byte with msb bits from nvmem */
    > > + rc = regmap_raw_read(nvmem->regmap,
    > > + cell->offset + cell->bytes - 1, &v, 1);
    > > + *p |= GENMASK(7, (nbits + bit_offset) % BITS_PER_BYTE) & v;
    > > +
    > > + }
    > > +
    > > + return buf;
    > > +}
    > > +
    > > +/**
    > > + * nvmem_cell_write(): Write to a given nvmem cell
    >
    > This isn't kernel doc notation. It should be like
    >
    > nvmem_cell_write - Write to a given nvmem cell

    Almost. Should be:

    nvmem_cell_write() - Write to a given nvmem cell

    Sascha

    --
    Pengutronix e.K. | |
    Industrial Linux Solutions | http://www.pengutronix.de/ |
    Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
    Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |


    \
     
     \ /
      Last update: 2015-06-17 10:41    [W:4.405 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site