Messages in this thread | | | From | Ashley Lai <> | Date | Tue, 16 Jun 2015 20:20:55 -0500 (CDT) | Subject | Re: [PATCH v2 2/2] TPM: remove unnecessary little endian conversion |
| |
Looks good.
Reviewed-by: Ashley Lai <ashley@ahsleylai.com>
Thanks, --Ashley
On Tue, 9 Jun 2015, Hon Ching(Vicky) Lo wrote:
> The base pointer for the event log is allocated in the local > kernel (in prom_instantiate_sml()), therefore it is already in > the host's endian byte order and requires no conversion. > > The content of the 'basep' pointer in read_log() stores the > base address of the log. This patch ensures that it is correctly > implemented. > > Signed-off-by: Hon Ching(Vicky) Lo <honclo@linux.vnet.ibm.com> > Signed-off-by: Joy Latten <jmlatten@linux.vnet.ibm.com> > --- > drivers/char/tpm/tpm_of.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/tpm/tpm_of.c b/drivers/char/tpm/tpm_of.c > index c002d1b..62a22ce 100644 > --- a/drivers/char/tpm/tpm_of.c > +++ b/drivers/char/tpm/tpm_of.c > @@ -24,7 +24,7 @@ int read_log(struct tpm_bios_log *log) > { > struct device_node *np; > const u32 *sizep; > - const __be64 *basep; > + const u64 *basep; > > if (log->bios_event_log != NULL) { > pr_err("%s: ERROR - Eventlog already initialized\n", __func__); > @@ -63,7 +63,7 @@ int read_log(struct tpm_bios_log *log) > > log->bios_event_log_end = log->bios_event_log + *sizep; > > - memcpy(log->bios_event_log, __va(be64_to_cpup(basep)), *sizep); > + memcpy(log->bios_event_log, __va(*basep), *sizep); > > return 0; > > -- > 1.7.1 > >
| |