lkml.org 
[lkml]   [2015]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/4] sched:Use correct nid while evaluating task weights
* Rik van Riel <riel@redhat.com> [2015-06-16 11:00:18]:

> On 06/16/2015 07:56 AM, Srikar Dronamraju wrote:
> > In task_numa_migrate(), while evaluating other nodes for group
> > consolidation, env.dst_nid is used instead of using the iterator nid.
> > Using env.dst_nid would mean dist is always the same. Infact the same
> > dist was calculated above while evaluating the preferred node.
> >
> > Fix the above to use the iterator nid.
>
> Good catch.
>
> > Also the task/group weights from the src_nid should be calculated
> > irrespective of numa topology type.
>
> If you look at score_nearby_nodes(), you will see that
> maxdist is only used when the topology is NUMA_BACKPLANE.
>
> The source score never changes when having a directly
> connected or NUMA_GLUELESS_MESH type system, so the source
> score does not need to be recalculated unless we are actually
> dealing with a NUMA_BACKPLANE topology.
>
> Looking forward to a v2 with just the first fix.

Okay, will fix accordingly.

--
Thanks and Regards
Srikar Dronamraju



\
 
 \ /
  Last update: 2015-06-16 20:01    [W:0.041 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site