lkml.org 
[lkml]   [2015]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/10] x86/intel_rdt: Intel haswell Cache Allocation enumeration
On Mon, 15 Jun 2015, Vikas Shivappa wrote:
> On Mon, 15 Jun 2015, Peter Zijlstra wrote:
>
> > On Fri, Jun 12, 2015 at 11:17:17AM -0700, Vikas Shivappa wrote:
> > > + /*
> > > + * Probe test for Haswell CPUs.
> > > + */
> > > + if (c->x86 == 0x6 && c->x86_model == 0x3f)
> > > + return hsw_probetest();
> >
> > Firstly, isn't a probe already a test?
>
> Will fix the name to hsw_probe
>
> >
> > Secondly, there's more HSW models:
> >
> > case 60: /* 22nm Haswell Core */
> > case 63: /* 22nm Haswell Server */
> > case 69: /* 22nm Haswell ULT */
> > case 70: /* 22nm Haswell + GT3e (Intel Iris Pro graphics) */
> >
> > Is this really only HSW server,
>
> Yes , this probe is only targeted at HSW servers as of now.
>
> or should they all be listed?

you should know, whether they support that feature and need that quirk,

Thanks

tglx



\
 
 \ /
  Last update: 2015-06-16 10:41    [W:0.062 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site