Messages in this thread | | | Date | Tue, 16 Jun 2015 08:05:19 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH RFC v5 2/4] crypto: add PKE API |
| |
On Mon, Jun 15, 2015 at 01:18:42PM -0700, Tadeusz Struk wrote: > > + * @setkey: Function invokes the algorithm specific set key function, which > + * knows how to decode and interpret the BER encoded key
We should split this into two functions: setpubkey and setprivkey.
> + * > + * @reqsize: Request context size required by algorithm implementation > + * @base: Common crypto API algorithm data structure > + */ > +struct akcipher_alg { > + int (*sign)(struct akcipher_request *req); > + int (*verify)(struct akcipher_request *req); > + int (*encrypt)(struct akcipher_request *req); > + int (*decrypt)(struct akcipher_request *req); > + int (*maxsize)(struct crypto_akcipher *tfm);
Hmm, we could actually get rid of maxsize by just having each function check the dst_len and if it is insufficient write the required length in it and then return an error.
Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |