Messages in this thread | | | Subject | Re: [PATCH 4/5] pcmcia: handle anonymous cards by generating a fake CIS | From | Alan Cox <> | Date | Mon, 15 Jun 2015 13:10:55 +0100 |
| |
> Unfortunately, this patch does not work well with all of the callers of > pccard_validate_cis(). While it helps for ds.c:pcmcia_card_add() and does > not matter for cistpl.c:pccard_show_cis(), it breaks the callback in > rsrc_nonstatic.c:readable():
I'm not sure it's the right way to do readable() but we seem to be stuck with that anyway.
The change looks good to me, and I will try and test it soon but it may take some time due to various other things going on in life. Can you submit it for 4.2 anyway and give it a bit of time for any screaming then push to stable ? The number of people using anonymous cards is pretty small these days so I think it's better to fix the regression you have and worry about anonymous cards as a secondary thing.
Alan
| |