Messages in this thread | | | Subject | Re: [PATCH v2] mtd: nand: support for Toshiba BENAND (Built-in ECC NAND) | From | Paul Bolle <> | Date | Fri, 12 Jun 2015 10:11:02 +0200 |
| |
On Fri, 2015-06-12 at 01:00 +0900, KOBAYASHI Yoshitake wrote: > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > index 5897d8d..050f0e9 100644
> +config MTD_NAND_BENAND > + tristate > + depends on MTD_NAND_BENAND_ENABLE > + default MTD_NAND > + > +config MTD_NAND_BENAND_ENABLE > + bool "Support for Toshiba BENAND (Built-in ECC NAND)" > + default y
Why do you default to 'y'?
> + help > + This enables support for Toshiba BENAND. > + Toshiba BENAND is a SLC NAND solution that automatically > + generates ECC inside NAND chip. > +
> --- /dev/null > +++ b/drivers/mtd/nand/nand_benand.c
> +EXPORT_SYMBOL(nand_benand_status_chk);
I didn't spot any users of nand_benand_status_chk() outside of this file. Why is this export needed?
Thanks,
Paul Bolle
| |