lkml.org 
[lkml]   [2015]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] mtd: nand: support for Toshiba BENAND (Built-in ECC NAND)
From
Date
On Fri, 2015-06-12 at 01:00 +0900, KOBAYASHI Yoshitake wrote:
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index 5897d8d..050f0e9 100644

> +config MTD_NAND_BENAND
> + tristate
> + depends on MTD_NAND_BENAND_ENABLE
> + default MTD_NAND
> +
> +config MTD_NAND_BENAND_ENABLE
> + bool "Support for Toshiba BENAND (Built-in ECC NAND)"
> + default y

Why do you default to 'y'?

> + help
> + This enables support for Toshiba BENAND.
> + Toshiba BENAND is a SLC NAND solution that automatically
> + generates ECC inside NAND chip.
> +

> --- /dev/null
> +++ b/drivers/mtd/nand/nand_benand.c

> +EXPORT_SYMBOL(nand_benand_status_chk);

I didn't spot any users of nand_benand_status_chk() outside of this
file. Why is this export needed?

Thanks,


Paul Bolle



\
 
 \ /
  Last update: 2015-06-12 10:41    [W:0.107 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site