lkml.org 
[lkml]   [2015]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/5] usb: dwc3: ep0: preparation for handling non maxpacket aligned transfers > 512
    On 06/10/2015 12:18 PM, Kishon Vijay Abraham I wrote:

    > No functional change. This is in preparation for handling non maxpacket
    > aligned transfers greater than bounce buffer size. This is basically to
    > avoid code duplication when using chained TRB transfers to handle
    > non maxpacket aligned transfers greater than bounce buffer size.

    > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
    > ---
    > drivers/usb/dwc3/ep0.c | 25 +++++++++++++++++--------
    > 1 file changed, 17 insertions(+), 8 deletions(-)

    > diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c
    > index 713e46a..4998074 100644
    > --- a/drivers/usb/dwc3/ep0.c
    > +++ b/drivers/usb/dwc3/ep0.c
    [...]
    > @@ -808,20 +812,24 @@ static void dwc3_ep0_complete_data(struct dwc3 *dwc,
    > }
    >
    > ur = &r->request;
    > + buf = ur->buf;
    > + remaining_ur_length = ur->length;
    >
    > length = trb->size & DWC3_TRB_SIZE_MASK;
    >
    > + maxp = ep0->endpoint.maxpacket;
    > +
    > if (dwc->ep0_bounced) {
    > - unsigned maxp = ep0->endpoint.maxpacket;
    > - unsigned transfer_size = roundup(ur->length, maxp);
    > + transfer_size = roundup((ur->length - transfer_size),
    > + maxp);

    The innermost parens shouldn't be needed (if thay are, fix the macro instead).

    [...]
    > @@ -941,7 +949,8 @@ static void __dwc3_ep0_do_control_data(struct dwc3 *dwc,
    > }
    >
    > maxpacket = dep->endpoint.maxpacket;
    > - transfer_size = roundup(req->request.length, maxpacket);
    > + transfer_size = roundup((req->request.length - transfer_size),
    > + maxpacket);

    Likewise.

    [...]

    WBR, Sergei



    \
     
     \ /
      Last update: 2015-06-10 20:41    [W:5.414 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site