lkml.org 
[lkml]   [2015]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iio: buffer: remove unneeded test
On 30/05/15 21:35, Laurent Navet wrote:
> The same code is executed regardless ret value, so this test
> can be removed.
> Also fix coverity scan CID 1268786.
>
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
Applied to the togreg branch of iio.git. Will push out
as testing when not stuck in a cleanroom with no net access
(but curiously with my less than entirely clean laptop ;)

Jonathan
> ---
> drivers/iio/industrialio-buffer.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
> index df919f4..e7fbcce 100644
> --- a/drivers/iio/industrialio-buffer.c
> +++ b/drivers/iio/industrialio-buffer.c
> @@ -806,8 +806,6 @@ static ssize_t iio_buffer_store_enable(struct device *dev,
> ret = __iio_update_buffers(indio_dev,
> NULL, indio_dev->buffer);
>
> - if (ret < 0)
> - goto done;
> done:
> mutex_unlock(&indio_dev->mlock);
> return (ret < 0) ? ret : len;
>



\
 
 \ /
  Last update: 2015-06-02 00:01    [W:0.106 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site