lkml.org 
[lkml]   [2015]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCHv4 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.
From
Date
On Mon, 2015-06-01 at 09:18 -0700, Moritz Fischer wrote:
> The Xilinx LogiCORE IP mailbox is a FPGA core that allows for
> interprocessor communication via AXI4 memory mapped / AXI4 stream
> interfaces.

trivia:

> diff --git a/drivers/mailbox/mailbox-xilinx.c b/drivers/mailbox/mailbox-xilinx.c
[]
> +static int xilinx_mbox_startup(struct mbox_chan *chan)
> +{
[]
> + dev_err(mbox->dev,
> + "failed to register mailbox interrupt:%d\n",
> + ret);
[]
> +static int xilinx_mbox_probe(struct platform_device *pdev)
> +{
[]
> + dev_err(&pdev->dev, "Couldn't get clk.\n");
[]
> + dev_info(&pdev->dev, "IRQ not found, fallback to polling.\n");
[]
> + dev_err(&pdev->dev, "Register mailbox failed\n");

Perhaps it' be nicer to consistently use a "no-period"
message style.




\
 
 \ /
  Last update: 2015-06-01 19:21    [W:0.063 / U:1.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site