Messages in this thread | | | Date | Mon, 1 Jun 2015 11:17:56 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf: introduce new two options for objdump. |
| |
Em Mon, Jun 01, 2015 at 03:58:16PM +0200, Martin Liška escreveu: > On 06/01/2015 02:54 PM, Arnaldo Carvalho de Melo wrote: > > Em Mon, Jun 01, 2015 at 01:10:06PM +0200, Martin Liška escreveu: > >> On 05/20/2015 03:05 PM, Arnaldo Carvalho de Melo wrote: > >>> Em Wed, May 20, 2015 at 03:02:01PM +0200, Martin Liška escreveu: > >>>> On 05/19/2015 04:33 PM, Arnaldo Carvalho de Melo wrote: > >>>>> Em Tue, May 19, 2015 at 08:29:58AM -0600, David Ahern escreveu: > > > > <SNIP> > > > >>>>>> Perhaps it should be generalized a bit? Right now we have symfs for the > >>>>>> location of the tree for binaries. What about a srcfs for a source tree? > >>>>> > >>>>> That is a good idea indeed. > >>>> > >>>> I was motivated to be able to annotate source code, realized out-of-box. More precisely, on a machine A > >>>> I run perf record, I moved the report file to machine B and I use these options to annotate source code. > > > > <SNIP> > > > >>> I guess so, and yeah, the feature implemented in your patch has value, > >>> thanks for collaborating! It is just that it may fit better as a > >>> complement to the --symfs stuff, that is also for off-box analysis: > > > >>> --symfs=<directory>:: > >>> Look for files with symbols relative to this directory. > > > >>> Thanks, will wait for further discussion before applying, > > > >> Are we going to wait any longer? It looks there's no discussion effort in this thread ;) > > > > I was waiting for you to follow thru on David's suggestion.
> Ah, I see. > My answer what kind of that a single new option is no going to enough. As explained in my previous > post, one needs to cut N components of a path and append a different path. > > I would follow option names starting with --objdump prefix.
David, do you agree?
- Arnaldo
| |