Messages in this thread | | | Subject | Re: [PATCH v2 1/4] NTP: rtc: Add CONFIG_RTC_SYSTOHC_DEVICE for NTP synchronization | From | Paul Bolle <> | Date | Mon, 01 Jun 2015 10:27:40 +0200 |
| |
On Fri, 2015-05-29 at 22:46 +0800, Xunlei Pang wrote: > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig
> config RTC_HCTOSYS_DEVICE > string "RTC used to set the system time" > - depends on RTC_HCTOSYS = y || RTC_SYSTOHC = y > + depends on RTC_HCTOSYS = y
RTC_HCTOSYS and RTC_SYSTOHC are bool symbols. The "= y" test is not needed and the common idiom is to use only depends on RTC_HCTOSYS
Since you're touching this you might as well switch to that idiom.
> default "rtc0" > help > The RTC device that will be used to (re)initialize the system > minutes if userspace reports synchronized NTP status.
> +config RTC_SYSTOHC_DEVICE > + string "RTC used to synchronize NTP adjustment" > + depends on RTC_SYSTOHC = y
Likewise.
> + default "rtc0" > + help > + The RTC device used for NTP synchronization. The main difference > + between RTC_HCTOSYS_DEVICE and RTC_SYSTOHC_DEVICE is that this > + one can sleep when setting time, because it runs in the workqueue > + context.
Paul Bolle
| |