Messages in this thread | | | Date | Fri, 8 May 2015 10:26:08 -0400 (EDT) | From | Alan Stern <> | Subject | RE: [PATCH 02/10] drivers:host:fsl: Use ehci_overrides structure for EHCI drv |
| |
On Fri, 8 May 2015, Ramneek Mehresh wrote:
> > On Thu, 7 May 2015, Ramneek Mehresh wrote: > > > > > Make use of ehci_driver_overrides structure for ehci-fsl driver > > > > > > Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com> > > > > You need to change a lot more than this. See commit a76dd463c58e (USB: > > EHCI: make ehci-orion a separate driver) as an example of what is needed. In > > the end, ehci-fsl.ko should be a new driver module, not compiled into ehci- > > hcd.ko. > > > I can definitely make this change, but this patch set is about OTG functionality > fix for all FSL QorIQ socs. Changes you are asking are for FSL Host driver. For that > I can float separate patch/patch set. Hence, I would request you to please accept the > Patch series in conext of OTG functionality fix
Accept which patch series? You have posted several different versions (and you failed to put the version numbers in the email Subject: lines, so I can't tell which patches belong to which version!).
I am not going to accept something that does a partial job of converting ehci-fsl into a separate module. Either do the entire conversion first, as a separate patch that is prerequisite to the OTG fix, or else fix the OTG stuff in a way that doesn't require ehci-fsl to be a separate module.
Alan Stern
| |