Messages in this thread | | | Date | Fri, 8 May 2015 13:59:54 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH 2/9] x86, perf: Add support for PEBSv3 profiling |
| |
> That's wrong. It does not respect perf_event_attr::clock_id.
Ok.
Are we really defaulting to real time now? (CLOCK_REALTIME == 0) What happens when ntpd is active and lets the time drift? That sounds very bad for event accuracy.
The clockid patch looks broken to me. At least it should default to MONOTONIC time, not just the time that happens to be 0 by accident.
Also I question we really need that many different kinds of time stamps.
-Andi
-- ak@linux.intel.com -- Speaking for myself only.
| |