Messages in this thread | | | Date | Fri, 08 May 2015 15:55:11 +0800 | From | "Lu, Baolu" <> | Subject | Re: [PATCH v2 1/3] usb: notify hcd when USB device suspend or resume |
| |
On 05/06/2015 10:35 PM, Alan Stern wrote: >> diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h >> >index 68b1e83..621d9b7 100644 >> >--- a/include/linux/usb/hcd.h >> >+++ b/include/linux/usb/hcd.h >> >@@ -383,7 +383,13 @@ struct hc_driver { >> > int (*find_raw_port_number)(struct usb_hcd *, int); >> > /* Call for power on/off the port if necessary */ >> > int (*port_power)(struct usb_hcd *hcd, int portnum, bool enable); >> >- >> >+ /* Call back to hcd when a USB device is going to suspend or just >> >+ * resumed. >> >+ */ >> >+ void (*device_suspend)(struct usb_hcd *, struct usb_device *udev, >> >+ pm_message_t msg); >> >+ void (*device_resume)(struct usb_hcd *, struct usb_device *udev, >> >+ pm_message_t msg); >> > }; > Your callbacks don't use the msg argument. What makes you think it is > needed?
'msg' arguments are not used in this patch series. I will remove them.
> > Alan Stern
Thank you, Baolu
| |