Messages in this thread | | | Date | Thu, 7 May 2015 00:39:18 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v4 4/7] mtrr, x86: Fix MTRR state checks in mtrr_type_lookup() |
| |
On Wed, May 06, 2015 at 09:23:31AM -0600, Toshi Kani wrote: > I have a question. Those bits define the bit field of enabled in struct > mtrr_state_type, which is defined in this header. Is it OK to only move > those definitions to other header?
I think we shouldn't expose stuff to userspace if we don't have to because then we're stuck with it. Userspace has managed so far without those defines so I don't see why we should export them now.
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply. --
| |