Messages in this thread | | | Date | Wed, 6 May 2015 19:00:24 +0530 | From | Srikar Dronamraju <> | Subject | Re: [PATCH 03/10] uprobes: Send SIGILL if handle_trampoline() fails |
| |
* Oleg Nesterov <oleg@redhat.com> [2015-05-04 14:48:58]:
> 1. It doesn't make sense to continue if handle_trampoline() fails, > change handle_swbp() to always return after this call. > > 2. Turn pr_warn() into uprobe_warn(), and change handle_trampoline() > to send SIGILL on failure. It is pointless to return to user mode > with the corrupted instruction_pointer() which we can't restore.
I agree
> > Signed-off-by: Oleg Nesterov <oleg@redhat.com> > ---
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com> -- Thanks and Regards Srikar Dronamraju
| |