Messages in this thread | | | Date | Tue, 05 May 2015 08:17:41 +0100 | From | Srinivas Kandagatla <> | Subject | Re: [RFC PATCH 12/14] ASoC: qcom: add apq8016 sound card support |
| |
On 03/05/15 01:01, Kenneth Westfield wrote: > On Thu, Apr 30, 2015 at 06:18:07PM +0100, Srinivas Kandagatla wrote: >> This patch adds apq8016 machine driver support. This patch was tested on >> two apq8016-sbc and msm8916-mtp board for both hdmi and analog audio >> features. > > apq8016 refers to the SOC, whereas machine drivers are board-specific. > Better to reference the board (or SOC-Codec combo) instead.
Yes, Initially I started of with apq8016-sbc, but as it also worked for mtp, I had to rename it to apq8016.
But you are right, I think renaming it to apq8016-sbc.c and msm8916-mtp.c would make sense.
--srini > >> --- >> sound/soc/qcom/Kconfig | 9 ++ >> sound/soc/qcom/Makefile | 1 + >> sound/soc/qcom/apq8016.c | 214 +++++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 224 insertions(+) >> create mode 100644 sound/soc/qcom/apq8016.c > >
| |