lkml.org 
[lkml]   [2015]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 048/221] sg: fix read() error reporting
    3.2.69-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Tony Battersby <tonyb@cybernetics.com>

    commit 3b524a683af8991b4eab4182b947c65f0ce1421b upstream.

    Fix SCSI generic read() incorrectly returning success after detecting an
    error.

    Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
    Acked-by: Douglas Gilbert <dgilbert@interlog.com>
    Signed-off-by: James Bottomley <JBottomley@Parallels.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/scsi/sg.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/drivers/scsi/sg.c
    +++ b/drivers/scsi/sg.c
    @@ -498,7 +498,7 @@ static ssize_t
    sg_new_read(Sg_fd * sfp, char __user *buf, size_t count, Sg_request * srp)
    {
    sg_io_hdr_t *hp = &srp->header;
    - int err = 0;
    + int err = 0, err2;
    int len;

    if (count < SZ_SG_IO_HDR) {
    @@ -527,8 +527,8 @@ sg_new_read(Sg_fd * sfp, char __user *bu
    goto err_out;
    }
    err_out:
    - err = sg_finish_rem_req(srp);
    - return (0 == err) ? count : err;
    + err2 = sg_finish_rem_req(srp);
    + return err ? : err2 ? : count;
    }

    static ssize_t


    \
     
     \ /
      Last update: 2015-05-05 04:21    [W:2.508 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site