Messages in this thread | | | Date | Fri, 29 May 2015 11:42:27 +0200 | Subject | Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() | From | Geert Uytterhoeven <> |
| |
On Fri, May 29, 2015 at 11:33 AM, Vinod Koul <vinod.koul@intel.com> wrote: > On Tue, May 26, 2015 at 04:25:57PM +0300, Peter Ujfalusi wrote: >> dma_request_slave_channel_compat() 'eats' up the returned error codes which >> prevents drivers using the compat call to be able to do deferred probing. >> >> The new wrapper is identical in functionality but it will return with error >> code in case of failure and will pass the -EPROBE_DEFER to the caller in >> case dma_request_slave_channel_reason() returned with it. > This is okay but am worried about one more warpper, how about fixing > dma_request_slave_channel_compat()
Then all callers of dma_request_slave_channel_compat() have to be modified to handle ERR_PTR first.
The same is true for (the existing) dma_request_slave_channel_reason() vs. dma_request_slave_channel().
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |