Messages in this thread Patch in this message | | | From | Julia Lawall <> | Subject | [PATCH 6/9] ssb: drop unneeded goto | Date | Thu, 28 May 2015 23:02:21 +0200 |
| |
From: Julia Lawall <Julia.Lawall@lip6.fr>
Delete jump to a label on the next line, when that label is not used elsewhere.
A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @r@ identifier l; @@
-if (...) goto l; -l: // </smpl>
Also drop the unneeded err variable.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
--- drivers/ssb/pci.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c index 0f28c08..d6ca4d3 100644 --- a/drivers/ssb/pci.c +++ b/drivers/ssb/pci.c @@ -1173,17 +1173,11 @@ void ssb_pci_exit(struct ssb_bus *bus) int ssb_pci_init(struct ssb_bus *bus) { struct pci_dev *pdev; - int err; if (bus->bustype != SSB_BUSTYPE_PCI) return 0; pdev = bus->host_pci; mutex_init(&bus->sprom_mutex); - err = device_create_file(&pdev->dev, &dev_attr_ssb_sprom); - if (err) - goto out; - -out: - return err; + return device_create_file(&pdev->dev, &dev_attr_ssb_sprom); }
| |