lkml.org 
[lkml]   [2015]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCH v3 0/3] alloc_huge_page/hugetlb_reserve_pages race
    Date
    While working on hugetlbfs fallocate support, I noticed the following
    race in the existing code. It is unlikely that this race is hit very
    often in the current code. However, if more functionality to add and
    remove pages to hugetlbfs mappings (such as fallocate) is added the
    likelihood of hitting this race will increase.

    alloc_huge_page and hugetlb_reserve_pages use information from the
    reserve map to determine if there are enough available huge pages to
    complete the operation, as well as adjust global reserve and subpool
    usage counts. The order of operations is as follows:
    - call region_chg() to determine the expected change based on reserve map
    - determine if enough resources are available for this operation
    - adjust global counts based on the expected change
    - call region_add() to update the reserve map
    The issue is that reserve map could change between the call to region_chg
    and region_add. In this case, the counters which were adjusted based on
    the output of region_chg will not be correct.

    In order to hit this race today, there must be an existing shared hugetlb
    mmap created with the MAP_NORESERVE flag. A page fault to allocate a huge
    page via this mapping must occur at the same another task is mapping the
    same region without the MAP_NORESERVE flag.

    The patch set does not prevent the race from happening. Rather, it adds
    simple functionality to detect when the race has occurred. If a race is
    detected, then the incorrect counts are adjusted.

    Review comments pointed out the need for documentation of the existing
    region/reserve map routines. This patch set also adds documentation
    in this area.

    v3:
    Created separate patch for new documentation created in v2
    Added VM_BUG_ON() to region add at suggestion of Naoya Horiguchi
    __vma_reservation_common keys off parameter commit for easier reading
    v2:
    Added documentation for the region/reserve map routines
    Created common routine for vma_commit_reservation and
    vma_commit_reservation to help prevent them from drifting
    apart in the future.

    Mike Kravetz (3):
    mm/hugetlb: document the reserve map/region tracking routines
    mm/hugetlb: compute/return the number of regions added by region_add()
    mm/hugetlb: handle races in alloc_huge_page and hugetlb_reserve_pages

    mm/hugetlb.c | 158 +++++++++++++++++++++++++++++++++++++++++++++++------------
    1 file changed, 128 insertions(+), 30 deletions(-)

    --
    2.1.0



    \
     
     \ /
      Last update: 2015-05-27 20:41    [W:4.274 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site