lkml.org 
[lkml]   [2015]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next v5 2/2] net: Adding support for Cavium ThunderX network controller
From
From: Aleksey Makarov <aleksey.makarov@caviumnetworks.com>
Date: Fri, 22 May 2015 18:28:16 -0700

> +#ifdef NOT_SUPPORTED_FOR_NOW
> +static int nicvf_set_coalesce(struct net_device *netdev,
> + struct ethtool_coalesce *cmd)
> +{
...
> +#ifdef NOT_SUPPORTED_FOR_NOW
> + .set_coalesce = nicvf_set_coalesce,
> +#endif
> + .get_ringparam = nicvf_get_ringparam,

Remove this completely. When you actually make it work and want to
enable it, you can re-add the code.

The upstream kernel is not your personal workspace :-)

> +#ifdef VNIC_RSS_SUPPORT

This is unconditionally defined in one of your headers, please remove
these ifdefs as they will never be false.

> +#ifdef VNIC_RSS_SUPPORT

Likewise.


\
 
 \ /
  Last update: 2015-05-25 23:41    [W:0.053 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site