Messages in this thread | | | Date | Mon, 18 May 2015 19:22:59 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH v3 01/11] block: make generic_make_request handle arbitrarily sized bios |
| |
On Mon, May 18, 2015 at 12:52:03PM -0400, Jeff Moyer wrote: > > + return bio_split(bio, split_sectors, GFP_NOIO, bs); > > Much of this function is cut-n-paste from blk-lib.c. Is there any way > to factor it out?
The code in blk-lib.c can go away now that any driver that cares does the split.
> > +static struct bio *blk_bio_segment_split(struct request_queue *q, > > + struct bio *bio, > > + struct bio_set *bs) > > +{ > > Funny name for a function that also merges segments. ;-) I admit I am > at a loss for coming up with a better name that won't overflow 80 > columns.
I'd keep the name and add a funny comment instead.
| |