Messages in this thread | | | Date | Fri, 15 May 2015 14:13:23 -0700 | From | Dave Hansen <> | Subject | Re: [PATCH 06/12] x86, pkeys: store protection in high VMA flags |
| |
On 05/15/2015 02:10 PM, Thomas Gleixner wrote: > On Thu, 7 May 2015, Dave Hansen wrote: >> +#ifdef CONFIG_ARCH_USES_HIGH_VMA_FLAGS >> +#define VM_HIGH_ARCH_1 0x100000000 /* bit only usable on 64-bit architectures */ > > Nit. Shouldn't this start with VM_HIGH_ARCH_0 ?
Yeah, it does make the later #defines look a bit funny. I modeled it after the "low" VM_ARCH_ flags which start at 1:
#define VM_ARCH_1 0x01000000 /* Architecture-specific flag */ #define VM_ARCH_2 0x02000000
I can change it to be 0 based though.
| |