| Date | Tue, 12 May 2015 17:44:03 -0400 | Subject | Re: [RFC v3 12/45] richacl: Compute maximum file masks from an acl | From | (J. Bruce Fields) |
| |
On Fri, Apr 24, 2015 at 01:04:09PM +0200, Andreas Gruenbacher wrote: > Compute upper bound owner, group, and other file masks with as few > permissions as possible without denying any permissions that the NFSv4 > acl in a richacl grants. > > This algorithm is used when a file inherits an acl at create time and > when an acl is set via a mechanism that does not provide file masks > (such as setting an acl via nfsd). When user-space sets an acl via > setxattr, the extended attribute already includes the file masks. > > Setting an acl also sets the file mode permission bits: they are > determined by the file masks; see richacl_masks_to_mode().
Thanks, the verbose comments are welcomed here, just one typo:
> + /* > + * @gmask contains all permissions which the group class is ever > + * allowed. We use it to avoid adding permissions to the group mask > + * from everyone@ allow aces which the group class is always denied > + * through other aces. For example, the following acl would otherwise > + * result in a group mask or rw:
s/or/of/ ?
--b.
|