Messages in this thread | | | Date | Mon, 11 May 2015 09:26:15 +0200 | From | Alexandre Belloni <> | Subject | Re: rtc: mc13xxx: fix obfuscated and wrong format string |
| |
On 20/02/2015 at 14:47:30 +0100, Rasmus Villemoes wrote : > According to C99, %2.s means 'print two spaces' (a precision of > . without following digits or * means 0). The kernel's printf > implementation, however, treats that case as if no precision was > given, but relying on that quirk is rather silly. Also, since no - > (aka left-justify) flag is given, the field with of 2 would then cause > the alarm->enabled case to come out as "o n". Deobfuscate it. > > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> > --- > drivers/rtc/rtc-mc13xxx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >
Rebased and applied on rtc-next, thanks.
-- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
| |