Messages in this thread | | | Date | Thu, 30 Apr 2015 16:39:31 +0900 | From | Chanwoo Choi <> | Subject | Re: [PATCH v9] extcon-axp288: Add axp288 extcon driver support |
| |
Hi Ram,
This patch has still one minor issue on below comment. But I fix it and will apply it on extcon-next branch after discussing how to apply this patch with Lee Jones (MFD maintainer).
Dear Lee, Do you want to send pull request after I make the immutable branch for this patch? or apply this patch on extcon git without any pull request?
Thanks, Chanwoo Choi
On 05/01/2015 12:14 AM, Ramakrishna Pallala wrote: > This patch adds the extcon support for AXP288 PMIC which > has the BC1.2 charger detection capability. Additionally > it also adds the USB mux switching support b/w SOC and PMIC > based on GPIO control. > > Signed-off-by: Ramakrishna Pallala <ramakrishna.pallala@intel.com> > Acked-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/extcon/Kconfig | 7 + > drivers/extcon/Makefile | 1 + > drivers/extcon/extcon-axp288.c | 385 ++++++++++++++++++++++++++++++++++++++++ > include/linux/mfd/axp20x.h | 5 + > 4 files changed, 398 insertions(+) > create mode 100644 drivers/extcon/extcon-axp288.c >
[snip]
> + vbus_attach ? EXTCON_GPIO_MUX_SEL_SOC > + : EXTCON_GPIO_MUX_SEL_PMIC); > + > + atomic_notifier_call_chain(&info->otg->notifier, > + vbus_attach ? USB_EVENT_VBUS : USB_EVENT_NONE, NULL); > + } > + > + if (notify_charger) > + extcon_set_cable_state(info->edev, cable, vbus_attach); > + > + /* Clear the flags on disconnect event */ > + if (!vbus_attach) > + notify_otg = notify_charger = false; > + > + return 0; > + > +dev_det_ret: > + if (ret < 0) > + dev_err(info->dev, "BC Mod detection error\n");
You miss the fix about following comment. "BC Mod detection error\n" -> "failed to detect BC Mod\n"
[snip]
| |