lkml.org 
[lkml]   [2015]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv5 02/28] rmap: add argument to charge compound page
On Wed, Apr 29, 2015 at 05:53:04PM +0200, Jerome Marchand wrote:
> On 04/23/2015 11:03 PM, Kirill A. Shutemov wrote:
> > diff --git a/mm/rmap.c b/mm/rmap.c
> > index dad23a43e42c..4ca4b5cffd95 100644
> > --- a/mm/rmap.c
> > +++ b/mm/rmap.c
> > @@ -1048,9 +1048,9 @@ static void __page_check_anon_rmap(struct page *page,
> > * (but PageKsm is never downgraded to PageAnon).
> > */
>
> The comment above should be updated to include the new argument.
>
...
> > @@ -1097,15 +1101,18 @@ void do_page_add_anon_rmap(struct page *page,
> > * Page does not have to be locked.
> > */
>
> Again, the description of the function should be updated.
>
...
> > @@ -1161,9 +1168,12 @@ out:
> > *
> > * The caller needs to hold the pte lock.
> > */
>
> Same here.

Will be fixed for v6. Thanks.

--
Kirill A. Shutemov


\
 
 \ /
  Last update: 2015-04-30 14:21    [W:0.094 / U:1.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site