lkml.org 
[lkml]   [2015]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"
On Fri, Mar 27, 2015 at 09:36:07PM +0100, Witos wrote:
> Changed bool to u8 to get rid of sparse warning.
>
> Signed-off-by: Piotr Witoslawski <pwitos@gmail.com>
> ---
> drivers/staging/speakup/fakekey.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/fakekey.c b/drivers/staging/speakup/fakekey.c
> index 4299cf4..3dfb6bd 100644
> --- a/drivers/staging/speakup/fakekey.c
> +++ b/drivers/staging/speakup/fakekey.c
> @@ -28,7 +28,7 @@
> #define PRESSED 1
> #define RELEASED 0
>
> -static DEFINE_PER_CPU(bool, reporting_keystroke);
> +static DEFINE_PER_CPU(u8, reporting_keystroke);

Why send this twice?

And again, I don't think this is fixing anything, what is wrong with
this code?

confused,

greg k-h


\
 
 \ /
  Last update: 2015-04-03 14:21    [W:0.090 / U:22.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site