Messages in this thread | | | Date | Fri, 3 Apr 2015 13:42:02 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool" |
| |
On Fri, Mar 27, 2015 at 09:29:43PM +0100, Witos wrote: > Changed bool to u8. > > Signed-off-by: Piotr Witoslawski <pwitos@gmail.com>
Your From: email line and signed-off-by: line names do not match, so I can't take this patch :(
Please fix up and resend.
> --- > drivers/staging/speakup/fakekey.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/speakup/fakekey.c b/drivers/staging/speakup/fakekey.c > index 4299cf4..3dfb6bd 100644 > --- a/drivers/staging/speakup/fakekey.c > +++ b/drivers/staging/speakup/fakekey.c > @@ -28,7 +28,7 @@ > #define PRESSED 1 > #define RELEASED 0 > > -static DEFINE_PER_CPU(bool, reporting_keystroke); > +static DEFINE_PER_CPU(u8, reporting_keystroke);
What is this fixing? Why can't we have a bool as a per-cpu variable? We are only writing true or false to it.
thanks,
greg k-h
| |