Messages in this thread | | | Date | Wed, 29 Apr 2015 16:14:37 +0300 | From | Adrian Hunter <> | Subject | Re: [PATCH V3 11/25] perf record: Add AUX area tracing Snapshot Mode support |
| |
On 28/04/15 16:24, Jiri Olsa wrote: > On Fri, Apr 24, 2015 at 10:29:53PM +0300, Adrian Hunter wrote: > > SNIP > >> char msg[512]; >> @@ -238,7 +302,8 @@ try_again: >> } >> >> if (perf_evlist__mmap_ex(evlist, opts->mmap_pages, false, >> - opts->auxtrace_mmap_pages, false) < 0) { >> + opts->auxtrace_mmap_pages, >> + opts->auxtrace_snapshot_mode) < 0) { >> if (errno == EPERM) { >> pr_err("Permission error mapping pages.\n" >> "Consider increasing " >> @@ -349,7 +414,7 @@ static int record__mmap_read_all(struct record *rec) >> } >> } >> >> - if (mm->base && >> + if (mm->base && !rec->opts.auxtrace_snapshot_mode && >> record__auxtrace_mmap_read(rec, mm) != 0) { >> rc = -1; >> goto out; >> @@ -404,6 +469,8 @@ static void workload_exec_failed_signal(int signo __maybe_unused, >> child_finished = 1; >> } >> >> +static void snapshot_sig_handler(int sig); > > seems there's no need for forward declaration, > you can define the function right here, no?
snapshot_sig_handler is dependent on "record" so the forward declaration does seem to be needed.
| |