lkml.org 
[lkml]   [2015]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:timers/core] alarmtimer: Get rid of unused return value
    Commit-ID:  b193217e6dc3f88b599b573b53e0e0f6671d969a
    Gitweb: http://git.kernel.org/tip/b193217e6dc3f88b599b573b53e0e0f6671d969a
    Author: Thomas Gleixner <tglx@linutronix.de>
    AuthorDate: Tue, 14 Apr 2015 21:09:18 +0000
    Committer: Thomas Gleixner <tglx@linutronix.de>
    CommitDate: Wed, 22 Apr 2015 17:06:52 +0200

    alarmtimer: Get rid of unused return value

    We want to get rid of the hrtimer_start() return value and the alarm
    timer return value is nowhere used. Remove it.

    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Acked-by: Peter Zijlstra <peterz@infradead.org>
    Cc: Preeti U Murthy <preeti@linux.vnet.ibm.com>
    Cc: Viresh Kumar <viresh.kumar@linaro.org>
    Cc: Marcelo Tosatti <mtosatti@redhat.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: John Stultz <john.stultz@linaro.org>
    Link: http://lkml.kernel.org/r/20150414203503.243910615@linutronix.de
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    ---
    include/linux/alarmtimer.h | 4 ++--
    kernel/time/alarmtimer.c | 11 ++++-------
    2 files changed, 6 insertions(+), 9 deletions(-)

    diff --git a/include/linux/alarmtimer.h b/include/linux/alarmtimer.h
    index a899402..52f3b7d 100644
    --- a/include/linux/alarmtimer.h
    +++ b/include/linux/alarmtimer.h
    @@ -43,8 +43,8 @@ struct alarm {

    void alarm_init(struct alarm *alarm, enum alarmtimer_type type,
    enum alarmtimer_restart (*function)(struct alarm *, ktime_t));
    -int alarm_start(struct alarm *alarm, ktime_t start);
    -int alarm_start_relative(struct alarm *alarm, ktime_t start);
    +void alarm_start(struct alarm *alarm, ktime_t start);
    +void alarm_start_relative(struct alarm *alarm, ktime_t start);
    void alarm_restart(struct alarm *alarm);
    int alarm_try_to_cancel(struct alarm *alarm);
    int alarm_cancel(struct alarm *alarm);
    diff --git a/kernel/time/alarmtimer.c b/kernel/time/alarmtimer.c
    index 0b55a75..7fbba63 100644
    --- a/kernel/time/alarmtimer.c
    +++ b/kernel/time/alarmtimer.c
    @@ -317,19 +317,16 @@ EXPORT_SYMBOL_GPL(alarm_init);
    * @alarm: ptr to alarm to set
    * @start: time to run the alarm
    */
    -int alarm_start(struct alarm *alarm, ktime_t start)
    +void alarm_start(struct alarm *alarm, ktime_t start)
    {
    struct alarm_base *base = &alarm_bases[alarm->type];
    unsigned long flags;
    - int ret;

    spin_lock_irqsave(&base->lock, flags);
    alarm->node.expires = start;
    alarmtimer_enqueue(base, alarm);
    - ret = hrtimer_start(&alarm->timer, alarm->node.expires,
    - HRTIMER_MODE_ABS);
    + hrtimer_start(&alarm->timer, alarm->node.expires, HRTIMER_MODE_ABS);
    spin_unlock_irqrestore(&base->lock, flags);
    - return ret;
    }
    EXPORT_SYMBOL_GPL(alarm_start);

    @@ -338,12 +335,12 @@ EXPORT_SYMBOL_GPL(alarm_start);
    * @alarm: ptr to alarm to set
    * @start: time relative to now to run the alarm
    */
    -int alarm_start_relative(struct alarm *alarm, ktime_t start)
    +void alarm_start_relative(struct alarm *alarm, ktime_t start)
    {
    struct alarm_base *base = &alarm_bases[alarm->type];

    start = ktime_add(start, base->gettime());
    - return alarm_start(alarm, start);
    + alarm_start(alarm, start);
    }
    EXPORT_SYMBOL_GPL(alarm_start_relative);


    \
     
     \ /
      Last update: 2015-04-22 21:41    [W:4.109 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site