Messages in this thread | | | Date | Wed, 22 Apr 2015 20:10:24 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [tpmdd-devel] [PATCH v2] tpm: enable PPI for TPM 2.0 |
| |
On Wed, Apr 22, 2015 at 11:22:43AM -0600, Jason Gunthorpe wrote: > On Wed, Apr 22, 2015 at 07:38:55PM +0300, Jarkko Sakkinen wrote: > > > > > +EXPORT_SYMBOL_GPL(kernfs_remove_by_name_ns); > > > > > > > > ?? > > > > I don't see this being called > > > > > > My bad, it is clutter in the patch file. I'll remove it. > > > > In fact this is needed because the driver uses kernfs_remove_by_name, > > which is an inline function that uses kernfs_remove_by_name_ns > > internally. > > Hum, that probably needs a sysfs_ analog - the paired removal > function for sysfs_link_group_to_kobj ?
Be very careful using that sysfs function, you shouldn't be doing that within a driver subsystem unless you know what you are doing :)
greg k-h
| |