Messages in this thread | | | Subject | Re: [PATCH 2/3 V2] time: allow gcc to fold constants when using | From | Joe Perches <> | Date | Wed, 22 Apr 2015 07:18:29 -0700 |
| |
On Wed, 2015-04-22 at 14:00 +0200, Thomas Gleixner wrote: > On Sun, 12 Apr 2015, Nicholas Mc Guire wrote: > > +extern unsigned long __msecs_to_jiffies(const unsigned int m); > > +#if HZ <= MSEC_PER_SEC && !(MSEC_PER_SEC % HZ) > > +static inline unsigned long _msecs_to_jiffies(const unsigned int m) > > +{ > > This should move the comments explaining the logic for each variant as > well. [] > It'd be nice to have this as two patches: > > 1) Factor out the code into inline helpers w/o adding anything
It also might be nice to use a single static inline with #ifdef blocks inside that inline rather than have 3 separate static inline msecs_to_jiffies.
> 2) Add the __builtin_constant_p() check
And please add the usecs_to_jiffies variants in a similar patch set.
| |