Messages in this thread | | | Date | Mon, 20 Apr 2015 14:04:26 +0100 | From | Peter Griffin <> | Subject | Re: [PATCH] ata: ahci_st: fixup layering violations / drvdata errors |
| |
Hi Tejun,
On Fri, 17 Apr 2015, Tejun Heo wrote: > On Thu, Apr 09, 2015 at 10:43:10AM +0100, Peter Griffin wrote: > > Yes I can test, although not until Saturday as I only have remote > > access to the board today & tomorrow and the hard drive isn't > > plugged in. > > What's the status on this patch? Should I push it through > for-4.1-fixes?
The layering violation which Brian identified does need fixing. However please don't take this patch as it currently is, as it causes a NULL ptr dereference.
I can send an updated version in a moment which: - 1) Fixes the conflict you will get when applying it for v4.1 (due to my "st_configure_oob must be called after IP is clocked" patch).
2) Fixes the crash which this patch introduces.
regards,
Peter.
| |