lkml.org 
[lkml]   [2015]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings
    From
    Hi Vinod,

    On Fri, Apr 17, 2015 at 11:59 PM, Vinod Koul <vinod.koul@intel.com> wrote:
    >
    >> /* Get DMA error interrupt */
    >> @@ -2076,7 +2035,6 @@ static struct platform_driver xgene_dma_driver = {
    >> .remove = xgene_dma_remove,
    >> .driver = {
    >> .name = "X-Gene-DMA",
    >> - .owner = THIS_MODULE,
    > I have already applied a patch for this

    Okay, I didn't pull latest git

    >
    >> .of_match_table = xgene_dma_of_match_ptr,
    >> },
    >> };
    >> @@ -2085,6 +2043,5 @@ module_platform_driver(xgene_dma_driver);
    >>
    >> MODULE_DESCRIPTION("APM X-Gene SoC DMA driver");
    >> MODULE_AUTHOR("Rameshwar Prasad Sahu <rsahu@apm.com>");
    >> -MODULE_AUTHOR("Loc Ho <lho@apm.com>");
    > And why this?

    I saw below warning reported by the kbuild robot test

    drivers/dma/xgene-dma.c:2088:1: sparse: symbol
    '__UNIQUE_ID_author__COUNTER__' has multiple initializers (originally
    initialized at drivers/dma/xgene-dma.c:2087)
    So, I kept only one author here.


    >
    > Fixes looks good though
    >
    > --
    > ~Vinod
    >> MODULE_LICENSE("GPL");
    >> MODULE_VERSION("1.0");
    >> --
    >> 1.8.2.1
    >>
    >
    > --


    \
     
     \ /
      Last update: 2015-04-20 05:21    [W:5.840 / U:0.488 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site