Messages in this thread | | | Date | Fri, 17 Apr 2015 10:15:46 +0200 | From | Matias Bjørling <> | Subject | Re: [PATCH 1/5 v2] blk-mq: Add prep/unprep support |
| |
On 04/17/2015 08:34 AM, Christoph Hellwig wrote: > On Wed, Apr 15, 2015 at 02:34:40PM +0200, Matias Bj??rling wrote: >> Allow users to hook into prep/unprep functions just before an IO is >> dispatched to the device driver. This is necessary for request-based >> logic to take place at upper layers. > > I don't think any of this logic belongs into the block layer. All this > should be library functions called by the drivers. >
Just the prep/unprep, or other pieces as well?
I like that struct request_queue has a ref to struct nvm_dev, and the variables in request and bio to get to the struct is in the block layer.
In the future, applications can have an API to get/put flash block directly. (using the blk_nvm_[get/put]_blk interface).
| |