Messages in this thread | | | Date | Fri, 10 Apr 2015 13:50:09 -0400 | From | Tom Talpey <> | Subject | Re: [PATCH v2 01/17] IB/Verbs: Implement new callback query_transport() for each HW |
| |
On 4/10/2015 1:10 PM, Doug Ledford wrote: > As per my above statement, rdma_transport* tests were testing the high > level transport type, rdma_port* types were testing link layers. iWARP > has an Eth link layer, so technically port_is_iwarp makes no sense. But > since all the other types had a check too, I included port_is_iwarp just > to be complete, and if you are going to ask if a specific port is iwarp > as a link layer, it makes sense to say yes if the transport is iwarp, > not if the link layer is eth.
Not wanting to split hairs, but I would not rule out the possibility of a future device supporting iWARP on one port and another RDMA protocol on another. One could also imagine softiWARP and softROCE co-existing atop a single ethernet NIC.
So, I disagree that port_is_iwarp() is a nonsequitur.
Tom.
| |