lkml.org 
[lkml]   [2015]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19 50/75] rtlwifi: Improve handling of IPv6 packets
    Date
    3.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Larry Finger <Larry.Finger@lwfinger.net>

    commit c8f0345586694a33f828bc6b177fb21eb1702325 upstream.

    Routine rtl_is_special_data() is supposed to identify packets that need to
    use a low bit rate so that the probability of successful transmission is
    high. The current version has a bug that causes all IPv6 packets to be
    labelled as special, with a corresponding low rate of transmission. A
    complete fix will be quite intrusive, but until that is available, all
    IPv6 packets are identified as regular.

    This patch also removes a magic number.

    Reported-and-tested-by: Alan Fisher <acf@unixcube.org>
    Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
    Cc: Alan Fisher <acf@unixcube.org>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/wireless/rtlwifi/base.c | 7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)

    --- a/drivers/net/wireless/rtlwifi/base.c
    +++ b/drivers/net/wireless/rtlwifi/base.c
    @@ -1314,8 +1314,11 @@ u8 rtl_is_special_data(struct ieee80211_
    }

    return true;
    - } else if (0x86DD == ether_type) {
    - return true;
    + } else if (ETH_P_IPV6 == ether_type) {
    + /* TODO: Handle any IPv6 cases that need special handling.
    + * For now, always return false
    + */
    + goto end;
    }

    end:



    \
     
     \ /
      Last update: 2015-04-10 16:21    [W:3.747 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site