Messages in this thread | | | Date | Wed, 1 Apr 2015 13:11:04 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH perf/core 2/2] perf-probe: Check the orphaned -x option |
| |
On Wed, Apr 01, 2015 at 07:25:42PM +0900, Masami Hiramatsu wrote: > To avoid probing in unintended binary, the orphaned -x option > must be checked and warned. > > Without this patch, following command sets up the probe in > the kernel. > ----- > # perf probe -a strcpy -x ./perf > Added new event: > probe:strcpy (on strcpy) > > You can now use it in all perf tools, such as: > > perf record -e probe:strcpy -aR sleep 1 > ----- > > But in this case, it seems that the user may want to probe > in the perf binary. With this patch, perf-probe correctly > handles the orphaned -x. > ----- > # perf probe -a strcpy -x ./perf > Error: -x/-m must follow the probe definitions. > ... > ----- > > Reported-by: Jiri Olsa <jolsa@redhat.com>
works nicely, thanks a lot!
Tested-by: Jiri Olsa <jolsa@kernel.org>
jirka
| |