Messages in this thread | | | Date | Wed, 1 Apr 2015 10:36:58 +0200 | Subject | Re: [PATCH v4 10/15] serial: stm32-usart: Add STM32 USART Driver | From | Maxime Coquelin <> |
| |
Hello Andy,
2015-03-31 18:45 GMT+02:00 Andy Shevchenko <andy.shevchenko@gmail.com>: > On Tue, Mar 31, 2015 at 7:24 PM, Maxime Coquelin > <mcoquelin.stm32@gmail.com> wrote: >> This drivers adds support to the STM32 USART controller, which is a >> standard serial driver. >> >> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> >> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com> > > Few minor comments below.
All your comments are valid, I will send a v5 shortly fixing this.
Thanks for the review, Maxime
> >> --- >> drivers/tty/serial/Kconfig | 17 + >> drivers/tty/serial/Makefile | 1 + >> drivers/tty/serial/stm32-usart.c | 743 +++++++++++++++++++++++++++++++++++++++ >> include/uapi/linux/serial_core.h | 3 + >> 4 files changed, 764 insertions(+) >> create mode 100644 drivers/tty/serial/stm32-usart.c >>
| |