Messages in this thread | | | Date | Fri, 6 Mar 2015 11:50:54 -0800 | Subject | Re: [PATCH v2 04/15] x86, kaslr: get kaslr_enabled back correctly | From | Yinghai Lu <> |
| |
On Fri, Mar 6, 2015 at 5:33 AM, Borislav Petkov <bp@suse.de> wrote:
> > "However, the setup_data linked list and thus the element which contains > kaslr_enabled is chained together using physical addresses. At the > time when we access it in the kernel proper, we're already running > with paging enabled and therefore must access it through its virtual > address." > > That's it, now how hard was to explain it that way?
No, I don't think your change log is right.
Actually the old code is using address as value.
if the old code would be like:
kaslr_enabled = (bool)(*(unsigned char *)(pa_data + sizeof(struct setup_data)));
then your change log would be good, but the old code is
kaslr_enabled = (bool)(pa_data + sizeof(struct setup_data));
| |