Messages in this thread | | | Date | Fri, 6 Mar 2015 11:39:44 +0000 | Subject | Re: [PATCH v5 4/6] arm64: kprobes instruction simulation support | From | Steve Capper <> |
| |
On 17 February 2015 at 23:11, David Long <dave.long@linaro.org> wrote: > From: Sandeepa Prabhu <sandeepa.prabhu@linaro.org> > > Kprobes needs simulation of instructions that cannot be stepped > from different memory location, e.g.: those instructions > that uses PC-relative addressing. In simulation, the behaviour > of the instruction is implemented using a copy of pt_regs. > > Following instruction catagories are simulated: > - All branching instructions(conditional, register, and immediate) > - Literal access instructions(load-literal, adr/adrp) > > Conditional execution is limited to branching instructions in > ARM v8. If conditions at PSTATE do not match the condition fields > of opcode, the instruction is effectively NOP. Kprobes considers > this case as 'miss'. > > Thanks to Will Cohen for assorted suggested changes. > > Signed-off-by: Sandeepa Prabhu <sandeepa.prabhu@linaro.org> > Signed-off-by: William Cohen <wcohen@redhat.com> > Signed-off-by: David A. Long <dave.long@linaro.org> > ---
Hi, Apologies for looking at these late (I was on holiday).
I've applied this series on top of 3.19, but I get the following compile error: arch/arm64/kernel/kprobes-arm64.c:23:34: fatal error: probes-simulate-insn.h: No such file or directory #include "probes-simulate-insn.h" ^ compilation terminated. scripts/Makefile.build:257: recipe for target 'arch/arm64/kernel/kprobes-arm64.o' failed
Is something missing from this patch?
Cheers, -- Steve
| |