lkml.org 
[lkml]   [2015]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.16.y-ckt 168/183] [media] Si2168: increase timeout to fix firmware loading
    Date
    3.16.7-ckt8 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jurgen Kramer <gtmkramer@xs4all.nl>

    commit 551c33e729f654ecfaed00ad399f5d2a631b72cb upstream.

    Increase si2168 cmd execute timeout to prevent firmware load failures. Tests
    shows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw' firmware.
    Increase timeout to a safe value of 70ms.

    Signed-off-by: Jurgen Kramer <gtmkramer@xs4all.nl>
    Reviewed-by: Antti Palosaari <crope@iki.fi>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/media/dvb-frontends/si2168.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
    index 23cc7f089974..f6846954b9a6 100644
    --- a/drivers/media/dvb-frontends/si2168.c
    +++ b/drivers/media/dvb-frontends/si2168.c
    @@ -39,7 +39,7 @@ static int si2168_cmd_execute(struct si2168 *s, struct si2168_cmd *cmd)

    if (cmd->rlen) {
    /* wait cmd execution terminate */
    - #define TIMEOUT 50
    + #define TIMEOUT 70
    timeout = jiffies + msecs_to_jiffies(TIMEOUT);
    while (!time_after(jiffies, timeout)) {
    ret = i2c_master_recv(s->client, cmd->args, cmd->rlen);

    \
     
     \ /
      Last update: 2015-03-06 11:21    [W:4.248 / U:1.340 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site