Messages in this thread | | | Date | Wed, 4 Mar 2015 12:34:19 -0600 | From | Kim Phillips <> | Subject | Re: [PATCH 1/3] crypto: caam: fix some compile warnings |
| |
On Wed, 4 Mar 2015 11:03:28 +0200 Cristian Stoica <cristian.stoica@freescale.com> wrote:
> On 03/04/2015 06:57 AM, yjin wrote: > > An alternative is moving the definitions to a ".c" file, but I don't > > think it will be fundamental different. > > I know I am fixing a potential error which doesn't exist now, it seems > > useless for the current upstream version, we can abandon my patch. But I > > still think the current implementation adds unnecessary restrictions for > > its users. > > I think that both dma_map_sg_chained and dma_unmap_sg_chained should go > away. They were added to support chained scatterlists, but as far as I > verified, dma_map_sg should handle that case as well. > > Kim, can you confirm this?
I don't see how, e.g., for one, dma_map_sg is I/O TLB implementation-dependent.
Kim
| |